Add v1.31, v1.30 to GHA matrix and use latest Kind k8s patch for each minor versions for e2e #8375
Conversation
kaovilai
force-pushed
the
run-e2e-latestk8s
branch
from
932670a to
0a46a9d
Compare
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
kaovilai
force-pushed
the
run-e2e-latestk8s
branch
from
0a46a9d to
9cd9317
Compare
kaovilai
changed the title
kaovilai
force-pushed
the
run-e2e-latestk8s
branch
2 times, most recently
from
9d758e0 to
0aaf0bb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
kaovilai
force-pushed
the
run-e2e-latestk8s
branch
from
0aaf0bb to
45776c3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8375 +/- ##
=======================================
Coverage 58.96% 58.96%
=======================================
Files 367 367
Lines 38895 38895
=======================================
Hits 22933 22933
Misses 14500 14500
Partials 1462 1462 ☔ View full report in Codecov by Sentry. |
kaovilai
changed the title
| # everything excluding older tags below 1.23. limits needs to be high enough to cover all latest versions | ||
| # grep -E "v[1-9]\.(2[3-9]|[3-9][0-9])" filters for v1.23 to v9.99 | ||
| run: | | ||
| echo "matrix={\"k8s\":$(wget -q -O - "https://hub.docker.com/v2/namespaces/kindest/repositories/node/tags?page_size=50" | grep -o '"name": *"[^"]*' | grep -o '[^"]*$' | grep -v -E "alpha|beta" | grep -E "v[1-9]\.(2[3-9]|[3-9][0-9])" | awk -F. '{if(!a[$1"."$2]++)print $1"."$2"."$NF}' | sort -r | sed s/v//g | jq -R -c -s 'split("\n")[:-1]')}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Could you give more explanation and comments to this piece of code awk -F. '{if(!a[$1"."$2]++)print $1"."$2"."$NF}'?
It's not easy to understand what it does.
There was a problem hiding this comment.
Another comment is we don't need to support that much of the KinD versions.
I suggest to deprecate the testing of v1.23 and v1.24.
There was a problem hiding this comment.
The awk removes older patches of the same release so only 1.30.1 runs, and not 1.30.0
kaovilai
force-pushed
the
run-e2e-latestk8s
branch
from
909f02b to
c14fb18
Compare
There was a problem hiding this comment.
can be a separate PR, but this file and .github/workflows/e2e-test-kind.yaml have a lot of duplication
It would be better to merge then together?
There was a problem hiding this comment.
that's an opinionated change over existing content of this pr. I think that can be discussed/opened separately.
There was a problem hiding this comment.
IIUC not combining jobs, just the workflow file right?
There was a problem hiding this comment.
Simplest change I think would be copying jobs.crd-check step to .github/workflows/e2e-test-kind.yaml
that would run pre steps (build-cli and setup-test-matrix) only once and crd-check and run-e2e-test would still run in parallel
kaovilai
force-pushed
the
run-e2e-latestk8s
branch
2 times, most recently
from
eeb0d5e to
e5ed0bb
Compare
Always test latest available patch version of each supported k8s version available in Kindest/node images. ie. This adds v1.31, v1.30 to test matrix and upgrade patch versions for others. Signed-off-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
run-e2e-latestk8s
branch
from
e5ed0bb to
f200f8f
Compare
Always test latest available patch version of each supported k8s version available in Kindest/node images.
ie. This adds v1.31, v1.30 to test matrix and upgrade patch versions for others. Removes v1.23 and v1.24.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.