-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --item-block-worker-count flag to velero install and server #8380
Conversation
Signed-off-by: Scott Seago <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8380 +/- ##
==========================================
- Coverage 58.96% 58.95% -0.01%
==========================================
Files 367 367
Lines 38895 38919 +24
==========================================
+ Hits 22933 22945 +12
- Misses 14500 14511 +11
- Partials 1462 1463 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the design it's not clear to me if threads will always be running, or started as needed. Could you clarify?
The thread creation won't be part of this PR, but the threads are long-running goroutines with the configured amount always available -- the main reason for this was that when we eventually expand this to allow multiple backups running at once, these goroutines will be shared among the running backups. So if, for example, you've configured 10 concurrent ItemBlocks and 2 concurrent backups, then there will be 10 threads processing blocks from both backups. (from the design): "The worker pool will be started by calling RunItemBlockWorkers in backupReconciler.SetupWithManager, passing in the worker count and reconciler context" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you for contributing to Velero!
Please add a summary of your change
This is the second PR related to phase 2 for backup performance improvements which adds a new flag
--item-block-worker-count
to velero install and server commands.Follow-on PRs will use this value to determine the number of goroutines to start for processing ItemBlocks
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.