Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crd-verify-kind action because e2e-test-kind already covered #8388

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Nov 11, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Remove the crd-verify-kind GitHub action because the e2e-test-kind already covered it.

The e2e-test-kind action runs the make e2e-test CLI. The E2E test already applies the CRDs during the installation of Velero.

// get the CRD definitions
cmd := exec.CommandContext(ctx, cli, args...)
fmt.Printf("Running cmd %q \n", cmd.String())
stdout, stderr, err := velerexec.RunCommand(cmd)
if err != nil {
return errors.Wrapf(err, "failed to run velero install dry run command with \"--crds-only\" option, stdout=%s, stderr=%s", stdout, stderr)
}
// apply the CRDs first
cmd = exec.CommandContext(ctx, "kubectl", "apply", "-f", "-")
cmd.Stdin = bytes.NewBufferString(stdout)
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
fmt.Printf("Applying velero CRDs...\n")
if err = cmd.Run(); err != nil {
return errors.Wrapf(err, "failed to apply the CRDs")
}

Does your change fix a particular issue?

Fixes #8384

Please indicate you've done the following:

@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Nov 11, 2024
@blackpiglet blackpiglet self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.96%. Comparing base (1fbd22f) to head (d5d5cc6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8388   +/-   ##
=======================================
  Coverage   58.96%   58.96%           
=======================================
  Files         367      367           
  Lines       38895    38895           
=======================================
  Hits        22933    22933           
  Misses      14500    14500           
  Partials     1462     1462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@blackpiglet blackpiglet changed the title Remove crd-verify-kind GitHub action because the e2e-test-kind already cove Remove crd-verify-kind GitHub action because the e2e-test-kind already covered Nov 12, 2024
@blackpiglet blackpiglet changed the title Remove crd-verify-kind GitHub action because the e2e-test-kind already covered Remove crd-verify-kind action because e2e-test-kind already covered Nov 12, 2024
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reasonerjt reasonerjt merged commit 8e23752 into vmware-tanzu:main Nov 12, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine e2e-test-kind and crd-verify-kind workflow files.
4 participants