Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 8394: move closeDataPath outside callbacks #8395

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue #8394, don't call closeDataPath in VGDP callbacks, otherwise, the VGDP cleanup will hang

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 58.95%. Comparing base (1fbd22f) to head (e5d6c48).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/pod_volume_backup_controller.go 0.00% 5 Missing ⚠️
pkg/controller/pod_volume_restore_controller.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8395      +/-   ##
==========================================
- Coverage   58.96%   58.95%   -0.02%     
==========================================
  Files         367      367              
  Lines       38895    38902       +7     
==========================================
  Hits        22933    22933              
- Misses      14500    14507       +7     
  Partials     1462     1462              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li marked this pull request as ready for review November 12, 2024 09:35
@Lyndon-Li Lyndon-Li merged commit 32a8c62 into vmware-tanzu:main Nov 13, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants