Add go buildinfo to velero to check toolchain version used. #8398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Dependencies
kaovilai
force-pushed
the
auto-toolchain
branch
4 times, most recently
from
b0a0cc1 to
106d45f
Compare
kaovilai
force-pushed
the
auto-toolchain
branch
2 times, most recently
from
7a82ae4 to
6cc53cf
Compare
3 tasks
kaovilai
force-pushed
the
auto-toolchain
branch
from
6cc53cf to
35f9f85
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8398 +/- ##
==========================================
- Coverage 58.96% 58.93% -0.03%
==========================================
Files 367 367
Lines 38895 38911 +16
==========================================
+ Hits 22933 22934 +1
- Misses 14500 14515 +15
Partials 1462 1462 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
kaovilai
changed the title
kaovilai
changed the title
Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
auto-toolchain
branch
from
35f9f85 to
ff8496c
Compare
kaovilai
commented
Nov 14, 2024
| @@ -69,6 +69,7 @@ func printVersion(w io.Writer, clientOnly bool, kbClient kbclient.Client, server | |||
| fmt.Fprintln(w, "Client:") | |||
| fmt.Fprintf(w, "\tVersion: %s\n", buildinfo.Version) | |||
| fmt.Fprintf(w, "\tGit commit: %s\n", buildinfo.FormattedGitSHA()) | |||
| fmt.Fprintf(w, "\tGo version: %s\n", buildinfo.GoVersion()) | |||
There was a problem hiding this comment.
Is this clear enough that it is not user's local go? do we want to say Built by Go Version instead?
reasonerjt
reviewed
Nov 18, 2024
|
|
||
| var ( | ||
| // Version is the current version of Velero, set by the go linker's -X flag at build time. | ||
| Version string | ||
|
|
||
| // goVersion is the version of Go that was used to build Velero | ||
| goBuildInfo *debug.BuildInfo |
There was a problem hiding this comment.
To be able to tell which golang version was used to build the code which can have implications around CVEs verification. ie someone built from a certain velero branch but used a different golang version. ie. #8397
There was a problem hiding this comment.
@reasonerjt just found
https://github.com/docker/cli/blob/6c76914532de7a39a202b3ef22519da319558560/cli/command/system/version.go#L93 have this :D
Just worth noting that it is a pattern out there that build includes both commit AND golang version that built it.
❯ docker version
Client: Docker Engine - Community
Version: 27.1.1
API version: 1.41 (downgraded from 1.46)
+Go version: go1.22.5
Git commit: 63125853e3
Built: Fri Jul 19 17:35:01 2024
OS/Arch: darwin/arm64
Context: default
Server: linux/arm64/rhcos-4.17
Podman Engine:
Version: 5.2.3
APIVersion: 5.2.3
Arch: arm64
BuildTime: 2024-10-07T07:47:17Z
Experimental: false
GitCommit:
+ GoVersion: go1.22.5 (Red Hat 1.22.5-1.el9)
KernelVersion: 5.14.0-427.40.1.el9_4.aarch64
MinAPIVersion: 4.0.0
Os: linux
Conmon:
Version: conmon version 2.1.12, commit: 9b3f2e7d010b1b512d88609d3a7b9a913bbaf1e0
Package: conmon-2.1.12-4.rhaos4.17.el9.aarch64
OCI Runtime (crun):
Version: crun version 1.17
commit: 000fa0d4eeed8938301f3bcf8206405315bc1017
rundir: /run/crun
spec: 1.0.0
+SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +CRIU +YAJL
Package: crun-1.17-1.rhaos4.17.el9.aarch64
Engine:
Version: 5.2.3
API version: 1.41 (minimum version 1.24)
+ Go version: go1.22.5 (Red Hat 1.22.5-1.el9)
Git commit:
Built: Mon Oct 7 07:47:17 2024
OS/Arch: linux/arm64
Experimental: falseLeaving this closed for now.
|
Closing as it is deemed not necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Facilitates requirements similar to #8397 that may come up in the future.
Helps validate go version used to build given that
go.modor commit hash of a built binary do not tell you this information.Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.