Refactor the schedule cases #8430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
added
kind/changelog-not-required
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8430 +/- ##
=======================================
Coverage 58.98% 58.98%
=======================================
Files 368 368
Lines 39000 39000
=======================================
Hits 23004 23004
Misses 14532 14532
Partials 1464 1464 ☔ View full report in Codecov by Sentry. |
blackpiglet
force-pushed
the
8323_fix
branch
from
b07af72 to
d53b382
Compare
blackpiglet
force-pushed
the
8323_fix
branch
10 times, most recently
from
ab82952 to
1e9b204
Compare
* Modify the OrderResource case's verification code. * Simplify the Periodical case. * Simplify the InProgess case. * Prettify the code. * Replace math/rand with crypto/rand * Replace PollUnitl with PollUntilContextTimeout Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
force-pushed
the
8323_fix
branch
from
1e9b204 to
226d50d
Compare
Lyndon-Li
approved these changes
Nov 25, 2024
kaovilai
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.