Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data mover exposer diagnostic #8482

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Dec 4, 2024

Fix issue #8125, log diagnostic info for data mover exposers when expose timeout

@Lyndon-Li Lyndon-Li force-pushed the data-mover-exposer-diagnostic branch from 8a3be72 to b607259 Compare December 4, 2024 06:50
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.18%. Comparing base (2e5df85) to head (34e417b).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
pkg/nodeagent/node_agent.go 44.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8482      +/-   ##
==========================================
+ Coverage   58.96%   59.18%   +0.22%     
==========================================
  Files         368      369       +1     
  Lines       39024    39253     +229     
==========================================
+ Hits        23009    23232     +223     
- Misses      14552    14557       +5     
- Partials     1463     1464       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li force-pushed the data-mover-exposer-diagnostic branch from e6a83a6 to b817f90 Compare December 5, 2024 08:48
@Lyndon-Li Lyndon-Li marked this pull request as ready for review December 5, 2024 08:49
pkg/controller/data_download_controller.go Outdated Show resolved Hide resolved
pkg/controller/data_upload_controller.go Outdated Show resolved Hide resolved
pkg/exposer/csi_snapshot.go Show resolved Hide resolved
@reasonerjt
Copy link
Contributor

It would be better to clarify in the commit message that it only dumps the info of related objects in the log.

@Lyndon-Li Lyndon-Li force-pushed the data-mover-exposer-diagnostic branch from b817f90 to 34e417b Compare December 10, 2024 06:00
@Lyndon-Li
Copy link
Contributor Author

It would be better to clarify in the commit message that it only dumps the info of related objects in the log.

Done, changed in the PR description and chagne-log

@Lyndon-Li Lyndon-Li requested a review from reasonerjt December 10, 2024 06:03
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ywk253100 ywk253100 merged commit 0224d99 into vmware-tanzu:main Dec 13, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants