Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the accepted info from annotations to DU/DD CR #8498

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Lyndon-Li
Copy link
Contributor

Related to issue #8485, move the acceptedByNode and acceptedTimestamp to Status of DU/DD CRD, reasons:

  1. They are informative for troubleshooting
  2. The are important info to control reconcile of DU/DD

@Lyndon-Li Lyndon-Li force-pushed the move-accept-info-to-du-dd-cr branch from 471af65 to 86082eb Compare December 9, 2024 08:39
@Lyndon-Li Lyndon-Li marked this pull request as ready for review December 9, 2024 08:41
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.03%. Comparing base (11f100f) to head (86082eb).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8498      +/-   ##
==========================================
- Coverage   59.04%   59.03%   -0.02%     
==========================================
  Files         369      369              
  Lines       39078    39068      -10     
==========================================
- Hits        23074    23064      -10     
  Misses      14543    14543              
  Partials     1461     1461              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ywk253100 ywk253100 merged commit 26661c7 into vmware-tanzu:main Dec 11, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants