Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.15] Issue 8433: add third party labels to data mover pods when the same labels exist in node-agent pods #8501

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue #8433, add third party labels to data mover pods when the same labels exist in node-agent pods

@Lyndon-Li Lyndon-Li marked this pull request as ready for review December 10, 2024 05:47
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.

Project coverage is 58.98%. Comparing base (a72aff2) to head (3f31730).
Report is 3 commits behind head on release-1.15.

Files with missing lines Patch % Lines
pkg/controller/data_download_controller.go 25.00% 5 Missing and 1 partial ⚠️
pkg/controller/data_upload_controller.go 40.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.15    #8501      +/-   ##
================================================
- Coverage         58.98%   58.98%   -0.01%     
================================================
  Files               367      367              
  Lines             38877    38903      +26     
================================================
+ Hits              22933    22947      +14     
- Misses            14482    14492      +10     
- Partials           1462     1464       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet
Copy link
Contributor

Could you please check whether this commit is needed cce4d48?
It seems this commit content is not shown in the diff content.
If it's not needed, please rebase and drop it.

@Lyndon-Li Lyndon-Li merged commit f499025 into vmware-tanzu:release-1.15 Dec 10, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants