Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue: backup schedule pause/unpause doesn't work #8512

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ywk253100
Copy link
Contributor

The issue is caused by the changes of controller-runtime: WithEventFilter() doesn't apply to WatchesRawSource(), this commit set Predicate for WatchesRawSource() seperatedly

Fixes #8437

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

The issue is caused by the changes of controller-runtime: WithEventFilter() doesn't apply to WatchesRawSource(),
this commit set Predicate for WatchesRawSource() seperatedly

Fixes vmware-tanzu#8437

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 59.18%. Comparing base (0224d99) to head (6e34c09).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/schedule_controller.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8512      +/-   ##
==========================================
- Coverage   59.19%   59.18%   -0.01%     
==========================================
  Files         369      369              
  Lines       39270    39275       +5     
==========================================
  Hits        23245    23245              
- Misses      14561    14566       +5     
  Partials     1464     1464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ywk253100 ywk253100 added this to the v1.16 milestone Dec 17, 2024
@ywk253100 ywk253100 merged commit a663cc4 into vmware-tanzu:main Dec 18, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

velero schedule pause doesn't work in main branch
3 participants