Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Go to 1.23 and toolchain to 1.23.6 #8717

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Feb 21, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Go 1.24.0 has been released on since 11 February 2025

This updates Go version from 1.22 to 1.23 and toolchain to 1.23.6

Does your change fix a particular issue?

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added Dependencies Pull requests that update a dependency file kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes labels Feb 21, 2025
@mmorel-35
Copy link
Contributor Author

/cc @sdx-jkataja

As you provided #8146 , I reused your commits and squashed them.

@mmorel-35 mmorel-35 force-pushed the go-1.23 branch 2 times, most recently from 9718dd8 to 8a3d477 Compare February 21, 2025 11:43
@mmorel-35 mmorel-35 marked this pull request as ready for review February 21, 2025 11:43
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.53%. Comparing base (6a6a237) to head (b6483fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8717      +/-   ##
==========================================
- Coverage   59.53%   59.53%   -0.01%     
==========================================
  Files         371      371              
  Lines       40196    40196              
==========================================
- Hits        23932    23929       -3     
- Misses      14767    14769       +2     
- Partials     1497     1498       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35
Copy link
Contributor Author

Please merge #8641 first

@anshulahuja98
Copy link
Collaborator

Please merge #8641 first

merged now.

Signed-off-by: Janne Kataja <[email protected]>

Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35 mmorel-35 marked this pull request as ready for review March 4, 2025 08:51
@github-actions github-actions bot requested review from reasonerjt and sseago March 4, 2025 08:51
@mmorel-35
Copy link
Contributor Author

Ready to be reviewed

@anshulahuja98
Copy link
Collaborator

@blackpiglet / @kaovilai
Any thoughts on merging this now vs after 1.16

@kaovilai
Copy link
Member

kaovilai commented Mar 4, 2025

For me, now probably better. Better karma for using supported go version

@kaovilai kaovilai mentioned this pull request Mar 4, 2025
3 tasks
@sseago sseago merged commit aa88d1c into vmware-tanzu:main Mar 4, 2025
45 of 46 checks passed
@mmorel-35 mmorel-35 deleted the go-1.23 branch March 4, 2025 15:35
@kaovilai
Copy link
Member

kaovilai commented Mar 4, 2025

Woot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants