Command Status and Report Generations #1854
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagarpsalvi, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
| @@ -17,6 +17,6 @@ def get_nsx_config(self): | |||
| return nsx_lb_config | |||
|
|
|||
| if __name__ == "__main__": | |||
| nsx_util = NSXUtil('admin', 'Admin!23Admin', '10.168.204.70', '443') | |||
| nsx_util = NSXUtil('admin', 'Admin!23Admin', '10.206.96.85', '443') | |||
There was a problem hiding this comment.
Do not push creds in repo
chaitanyaavi
reviewed
Dec 2, 2021
| import os | ||
| from pprint import PrettyPrinter | ||
|
|
||
| SUPPORTED_ALB_OBJECTS = [ |
There was a problem hiding this comment.
Move this information to yaml file and read from file
chaitanyaavi
reviewed
Dec 2, 2021
| "Webhook" | ||
| ] | ||
|
|
||
| albObjectType = { |
There was a problem hiding this comment.
Move this to command status yaml
chaitanyaavi
reviewed
Dec 2, 2021
|
|
||
| # SUPPORTED_ALB_OBJECTS = ['VirtualService'] | ||
|
|
||
| NOT_APPLICABLE = ['url', 'uuid', 'tenant_ref'] |
There was a problem hiding this comment.
Move to command status yaml
chaitanyaavi
reviewed
Dec 2, 2021
| output_dir, report_name, vs_level_status) | ||
|
|
||
| def get_port_by_protocol(self, protocol): | ||
| """ |
chaitanyaavi
reviewed
Dec 2, 2021
| if skipped_setting['pools']: | ||
| return skipped_setting | ||
|
|
||
| def vs_complexity_level(self): |
There was a problem hiding this comment.
Remove unused code if can be reused from F5 migration tool utils then move to base util class
-vs skip for unsupported topology -SSL cipher string issue -cleanup of parameters -added examples of parameter usage -seperate cleanup script
-Added example for config file and moved sample files to test directory -Renamed controller parameters -Removed unwanted/unsupported parameters -Fixed warning messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Done