Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deckhouse improvements #620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

name212
Copy link

@name212 name212 commented Mar 17, 2024

Description

Hi. I'm a maintainer of Deckhouse Kubernets Platform
As part of the platform, we have implemented support for vCloud Director. But we had to make a few changes.
Due to the fact that the first releases of support for the first providers (e.g. AWS)were based on Machine Controller Mananger, we implemented control-plane deployment with our scripts, so for backwards compatibility we don't use all features of the Cluster API, but use ClusterAPI providers to deploy worker-machines in the cloud.

Hence we needed to:

  • use a different port for webhook (the webhook-port option was added as part of this pull request);
  • refuse to order LoadBalancer for the control plane and use the KUBERNETES_SERVICE_HOST environment variable for the control-plane IP (the use-kubernetes-host-env-as-control-plane-host option was added as part of this pull request, if the option was not passed, the old logic is used);
  • pass hostname through guestinfo (option pass-hostname-by-guest-info)
  • refuse additional checks for successful cloud-init start (option skip-post-bootstrap-phases-checking).
    All of the above changes are easy to implement and are covered by the corresponding options in single code sections and are easy to test.
    The biggest change is support getting IP address via DHCP. This is quite a big change and affects the basic business logic of creating a machine.
    To enable it, the default-network-mode-for-new-vm option is used When using the DHCP value, bootstrap the machine as follows:
  • ordering the machine in the cloud;
  • resizing the root disc, this allows the OS to run faster on the machine and obtain an address via DHCP;
  • starting the virtual machine and waiting for an IP address.
    When making changes, we tried to make our changes under the flag and keep the logic we have now.

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #


This change is Reviewable

@vmwclabot
Copy link
Member

@name212, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@arunmk
Copy link
Collaborator

arunmk commented Mar 18, 2024

hi @name212 could you please add a description of the changes that you have in the PR

EDIT: sorry, I see that it is a WIP. So I will wait for the actual PR.

@vmwclabot
Copy link
Member

@name212, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@name212 name212 marked this pull request as ready for review March 30, 2024 09:48
@vmwclabot
Copy link
Member

@name212, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Need an valid address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants