Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi. I'm a maintainer of Deckhouse Kubernets Platform
As part of the platform, we have implemented support for vCloud Director. But we had to make a few changes.
Due to the fact that the first releases of support for the first providers (e.g. AWS)were based on Machine Controller Mananger, we implemented control-plane deployment with our scripts, so for backwards compatibility we don't use all features of the Cluster API, but use ClusterAPI providers to deploy worker-machines in the cloud.
Hence we needed to:
webhook-port
option was added as part of this pull request);use-kubernetes-host-env-as-control-plane-host
option was added as part of this pull request, if the option was not passed, the old logic is used);pass-hostname-by-guest-info
)skip-post-bootstrap-phases-checking
).All of the above changes are easy to implement and are covered by the corresponding options in single code sections and are easy to test.
The biggest change is support getting IP address via DHCP. This is quite a big change and affects the basic business logic of creating a machine.
To enable it, the
default-network-mode-for-new-vm
option is used When using the DHCP value, bootstrap the machine as follows:When making changes, we tried to make our changes under the flag and keep the logic we have now.
Checklist
API Changes
Are there API changes?
If yes, please fill in the below
./examples/capi-quickstart.yaml
?./infrastructure-vcd/v1.0.0/
?Issue
If applicable, please reference the relevant issue
Fixes #
This change is