Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAFV-393: Do not update VAppMetadataUpdated anymore #636

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arunmk
Copy link
Collaborator

@arunmk arunmk commented Apr 1, 2024

Description

Please provide a brief description of the changes proposed in this Pull Request

  • This stops updating the vAppMetadataUpdated field. The VCDResourceSet already contains the list of vApps consumed by the cluster. This field is not needed anymore.
  • This does not remove any race scenarios.
  • This field can remove the number of VCD API calls while a cluster is being created by 1 call per reentry to the reconciler. That is a small tax when the number of calls is considered. This can be reduced by other means as well.

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #


This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants