AV-228104 add hostrule aliases in map during boot-up #271
Conversation
|
build amko |
|
build amko |
| hostRules, err := c.hrClientSet.AkoV1beta1().HostRules("").List(context.TODO(), metav1.ListOptions{}) | ||
| if err != nil { | ||
| gslbutils.Errf("cluster: %s, error in fetching hostrules, %s", c.name, err.Error()) | ||
| return |
There was a problem hiding this comment.
@arihantg should we continue to next cluster, in case if there is an issue with one cluster to fetch hostrule objects?
There was a problem hiding this comment.
No. If we continue we might delete existing GSLB services or pool members.
gslb/ingestion/bootup_handler.go
Outdated
| @@ -184,8 +184,8 @@ func HandleBootup(cfg *restclient.Config) (bool, error) { | |||
| } | |||
|
|
|||
| if len(amkoClusterList.Items) == 0 { | |||
| gslbutils.Logf("No AMKOCluster object found, AMKO would start as leader") | |||
| return true, nil | |||
| gslbutils.Logf("No AMKOCluster object found, AMKO would stop") | |||
There was a problem hiding this comment.
Can we re-phrase it as No AMKOCluster object found, rebooting AMKO?
There was a problem hiding this comment.
Do we have any bootuptest for it?
There was a problem hiding this comment.
Updated the log and added test
gslb/ingestion/bootup_handler.go
Outdated
| @@ -184,8 +184,8 @@ func HandleBootup(cfg *restclient.Config) (bool, error) { | |||
| } | |||
|
|
|||
| if len(amkoClusterList.Items) == 0 { | |||
| gslbutils.Logf("No AMKOCluster object found, AMKO would start as leader") | |||
| return true, nil | |||
| gslbutils.Logf("No AMKOCluster object found, AMKO would stop") | |||
There was a problem hiding this comment.
Are we fixing another issue as part of this issue? Should we mention that ID to track it?
There was a problem hiding this comment.
Have added AV-228538 in description. Also present in commit message
arihantg
force-pushed
the
multiplecreatedby
branch
2 times, most recently
from
473d6c6 to
4eb2b0f
Compare
|
build amko |
http://10.80.35.67/cf.html -> FT results for hostrule with customfqdn true
http://10.80.35.67/ns.html -> FT results for hostrule with customfqdn false
This Pr also fixes AV-228538 where we reboot in case amkocluster item list is empty