Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more VM class methods, rename VDC to Region Quota, add more RegionQuotaStoragePolicy methods, fix NSX #748

Merged
merged 25 commits into from
Feb 12, 2025

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Feb 6, 2025

  • Rename govcd.TmVdc to govcd.RegionQuota to use same naming as VCFA UI. types.TmVdc remains the same to respect the original name from the API type.

  • Added VCDClient.AssignVmClassesToRegionQuota as a convenient method to assign VM classes without having to fetch the Region Quota.

  • Rename govcd.TmVdcStoragePolicy to govcd.RegionQuotaStoragePolicy to use same naming as VCFA UI. types.VirtualDatacenterStoragePolicy remains the same to respect the original name from the API type.

Side changes:

  • Removed NetworkProviderScope from NsxtManagerOpenApi as it is not recognized anymore.
  • Added new NsxtManagerOpenApi properties

abarreiro added 17 commits February 6, 2025 14:42
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro marked this pull request as ready for review February 11, 2025 14:42
@adambarreiro adambarreiro changed the title Add more VM class methods Add more VM class methods, rename VDC to Region Quota, add more RegionQuotaStoragePolicy methods Feb 11, 2025
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro changed the title Add more VM class methods, rename VDC to Region Quota, add more RegionQuotaStoragePolicy methods Add more VM class methods, rename VDC to Region Quota, add more RegionQuotaStoragePolicy methods, fix NSX Feb 11, 2025
abarreiro added 4 commits February 12, 2025 10:20
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
@lvirbalas
Copy link
Collaborator

Note: TM-specific features are in tm_*.go files (with the prefix). While the functions themselves only have Tm prefix where a distinction from a same-named VCD function is needed (so, mostly there is no prefix).

Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro self-assigned this Feb 12, 2025
@Didainius Didainius mentioned this pull request Feb 12, 2025
@adambarreiro adambarreiro merged commit 333338d into vmware:main Feb 12, 2025
2 checks passed
@adambarreiro adambarreiro deleted the fix-org-vdc branch February 12, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants