Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing K8 max version logic #1336

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Changing K8 max version logic #1336

merged 2 commits into from
Dec 23, 2023

Conversation

akshayhavile
Copy link
Contributor

No description provided.

@Dhivyaaj
Copy link

Dhivyaaj commented Dec 4, 2023

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@akshayhavile
Copy link
Contributor Author

skip jira-id-check

@akshayhavile
Copy link
Contributor Author

build ako

1 similar comment
@akshayhavile
Copy link
Contributor Author

build ako

DixitAakash
DixitAakash reviewed Dec 6, 2023
View reviewed changes
cmd/ako-main/main.go Outdated
@@ -175,10 +175,8 @@ func InitializeAKC() {
if lib.CompareVersions(serverVersion, ">", lib.GetK8sMaxSupportedVersion()) ||
lib.CompareVersions(serverVersion, "<", lib.GetK8sMinSupportedVersion()) {
// Temporary check of supporting 1.28 till we change it in version matrix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment needs to be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

DixitAakash
DixitAakash previously approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@DixitAakash DixitAakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, only one comment needs to be removed.

@DixitAakash
Copy link
Contributor

build ako

@akshayhavile akshayhavile force-pushed the master-changeK8maxVersion branch from d4d3d12 to d219a7a Compare December 7, 2023 06:27
@Dhivyaaj
Copy link

Dhivyaaj commented Dec 7, 2023

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@akshayhavile
Copy link
Contributor Author

skip jira-id-check

arihantg
arihantg previously approved these changes Dec 7, 2023
View reviewed changes
@akshayhavile
Copy link
Contributor Author

build ako

1 similar comment
@akshayhavile
Copy link
Contributor Author

build ako

@akshayhavile akshayhavile force-pushed the master-changeK8maxVersion branch from d219a7a to e3d6507 Compare December 11, 2023 05:32
@Dhivyaaj
Copy link

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@akshayhavile
Copy link
Contributor Author

skip jira-id-check

@akshayhavile
Copy link
Contributor Author

build ako

2 similar comments
@akshayhavile
Copy link
Contributor Author

build ako

@akshayhavile
Copy link
Contributor Author

build ako

aaha97
aaha97 previously approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@aaha97 aaha97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaha97
Copy link
Contributor

aaha97 commented Dec 14, 2023

build ako

@akshayhavile
Copy link
Contributor Author

build ako

arihantg
arihantg previously approved these changes Dec 14, 2023
View reviewed changes
@akshayhavile
Copy link
Contributor Author

build ako

3 similar comments
@akshayhavile
Copy link
Contributor Author

build ako

@akshayhavile
Copy link
Contributor Author

build ako

@akshayhavile
Copy link
Contributor Author

build ako

@akshayhavile akshayhavile dismissed stale reviews from arihantg and aaha97 via 26f1fd7 December 22, 2023 23:12
@akshayhavile akshayhavile force-pushed the master-changeK8maxVersion branch from e3d6507 to 26f1fd7 Compare December 22, 2023 23:12
@Dhivyaaj
Copy link

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@akshayhavile
Copy link
Contributor Author

skip jira-id-check

@akshayhavile
Copy link
Contributor Author

build ako

@akshayhavile
Copy link
Contributor Author

It was previously approved so merging.

@akshayhavile akshayhavile merged commit b225814 into vmware:master Dec 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arihantg arihantg arihantg left review comments

@aaha97 aaha97 aaha97 left review comments

@pkoshtavmware pkoshtavmware Awaiting requested review from pkoshtavmware

@saurabhvaidvmware saurabhvaidvmware Awaiting requested review from saurabhvaidvmware

@DixitAakash DixitAakash Awaiting requested review from DixitAakash

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akshayhavile @Dhivyaaj @DixitAakash @aaha97 @arihantg @vmwclabot