network-config-manager: Fix incorrect IPv6 config source #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue - nmctl status <device> -j is showing ConfigSource as foreign for all kind of address like static, dynamic and foreign. Now on existing flow to get a link address info nmctl get the info from dbus and parse the info similar for address as well. While parsing the address from json object to ip, prefix length is not appended to address. Hence ip matching with address always failing for IPv6, cause of this ConfigSource always set to foreign regardless of address is static or dynamic. Fix - Fixed in json_array_to_ip parsing to take care of prefix value as well while returning the ip address after parsing the json object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - nmctl status -j is showing ConfigSource as foreign for all kind of address like static, dynamic and foreign.
Now on existing flow to get a link address info nmctl get the info from dbus and parse the info similar for address as well. While parsing the address from json object to ip, prefix length is not appended to address. Hence ip matching with address always failing for IPv6, cause of this ConfigSource always set to foreign regardless of address is static or dynamic.
Fix - Fixed in json_array_to_ip parsing to take care of prefix value as well while returning the ip address after parsing the json object.