Set ipv4 set ipv6 changes #711
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue - nmctl status <device> -j is showing ConfigSource as foreign for all kind of address like static, dynamic and foreign. Now on existing flow to get a link address info nmctl get the info from dbus and parse the info similar for address as well. While parsing the address from json object to ip, prefix length is not appended to address. Hence ip matching with address always failing for IPv6, cause of this ConfigSource always set to foreign regardless of address is static or dynamic. Fix - Fixed in json_array_to_ip parsing to take care of prefix value as well while returning the ip address after parsing the json object.
Issue: This issue exist with set-ipv4 and set-ipv6 command. While setting LinkLocalAddressing for both IPv4 and IPv6 one after another the LinkLocalAddressing only preserving the last command value in this case it would be LinkLocalAddressing=ipv6 instead it should be LinkLocalAddressing=yes. Fix: Addressing this issue in both commands now nmctl check for existing value and based on that it will update the LinkLocalAddressing parameter.
Issue: While Setting DNS for IPv4 or IPv6 it always override the existing DNS with newly added one even its not duplicate. Fix: nmctl is now taking care of existing DNS value and newly added as well while setting IPv4 DNS or IPv6 DNS. It will keep all the unique DNS addresses irrespective of IPv4/IPv6.
… command.
Syntax - nmctl set-ipv4/set-ipv6 dev <DEVICE> domains <SERVER1,SERVER2...>
Example - nmctl set-ipv4 dev test99 domains example1.com,example2.com
nmctl set-ipv6 dev test99 domains example3.com,example3.com
…t-ipv6 command.
Syntax: nmctl set-ipv4/set-ipv6 dev <DEVICE> use-domains <route|BOOLEAN>
Example: nmctl set-ipv4 dev dummy1 use-domains yes
nmctl set-ipv6 dev dummy1 use-domains route
…v4 command.
Syntax: nmctl set-ipv4 dev <DEVICE> cid <ClientIdentifierValue>
nmctl set-ipv4 dev dummy1 cid mac
The test is a combination of IPv4, IPv6, DNS, Domains, UseDns, UseDomains, SendRelease, LinkLocalAddressing, ClientIdentifier etc.
This reverts commit 87a7bc6.
ntsbtz
force-pushed
the
set-ipv4_set-ipv6_changes
branch
from
6143f8f
to
6bff70b
Compare
… and set-ipv6 command. 1. LinkLocalAddressing overrides while setting ipv6 over ipv4 and vice versa. 2. DNS settings got overrides while setting ipv6 DNS over ipv4 DNS and vice versa. 3. Domains option added in both set-ipv4 and set-ipv6 command to set multiple domain names. 4. UseDomains option added in both set-ipv4 and set-ipv6 command to set UseDomains. 5. ClientIdentifier option added in set-ipv4 command to set ClientIdentifier. 6. Adding multiple test for set-ipv4 and set-ipv6 command. The test is a combination of IPv4, IPv6, DNS, Domains, UseDns, UseDomains, SendRelease, LinkLocalAddressing, ClientIdentifier etc.
ntsbtz
force-pushed
the
set-ipv4_set-ipv6_changes
branch
from
6bff70b
to
47f221f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.