Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: errcheck #54

Merged
merged 1 commit into from
Jan 27, 2025
Merged

chore: errcheck #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions hcx/activation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ func PostActivate(c *Client, body ActivateBody) (ActivateBody, error) {
resp := ActivateBody{}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return resp, err
}

req, err := http.NewRequest("POST", fmt.Sprintf("%s:9443/api/admin/global/config/hcx", c.HostURL), &buf)
if err != nil {
Expand Down Expand Up @@ -94,7 +98,11 @@ func DeleteActivate(c *Client, body ActivateBody) (ActivateBody, error) {
resp := ActivateBody{}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return resp, err
}

req, err := http.NewRequest("DELETE", fmt.Sprintf("%s:9443/api/admin/global/config/hcx", c.HostURL), &buf)
if err != nil {
Expand Down
6 changes: 5 additions & 1 deletion hcx/certificate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ func InsertCertificate(c *Client, body InsertCertificateBody) (InsertCertificate
resp := InsertCertificateResult{}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return resp, err
}

req, err := http.NewRequest("POST", fmt.Sprintf("%s/hybridity/api/admin/certificates", c.HostURL), &buf)
if err != nil {
Expand Down
5 changes: 4 additions & 1 deletion hcx/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,10 @@ func (c *Client) HcxConnectorAuthenticate() error {

// Check if SSO is ready
var xmlmessage Entries
xml.Unmarshal(body, &xmlmessage)
err = xml.Unmarshal(body, &xmlmessage)
if err != nil {
return err
}

certificate_pb := false
for _, j := range xmlmessage.Entry {
Expand Down
6 changes: 5 additions & 1 deletion hcx/compute_profile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ func InsertComputeProfile(c *Client, body InsertComputeProfileBody) (InsertCompu
resp := InsertComputeProfileResult{}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return resp, err
}

req, err := http.NewRequest("POST", fmt.Sprintf("%s/hybridity/api/interconnect/computeProfiles", c.HostURL), &buf)
if err != nil {
Expand Down
6 changes: 5 additions & 1 deletion hcx/l2_extension.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,11 @@ func InsertL2Extension(c *Client, body InsertL2ExtensionBody) (InsertL2Extention
resp := InsertL2ExtentionResult{}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return resp, err
}

req, err := http.NewRequest("POST", fmt.Sprintf("%s/hybridity/api/l2Extensions", c.HostURL), &buf)
if err != nil {
Expand Down
5 changes: 4 additions & 1 deletion hcx/location.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ type GetLocationResult struct {
func SetLocation(c *Client, body SetLocationBody) error {

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
return err
}

req, err := http.NewRequest("PUT", fmt.Sprintf("%s:9443/api/admin/global/config/location", c.HostURL), &buf)
if err != nil {
Expand Down
24 changes: 20 additions & 4 deletions hcx/network_profile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,11 @@ func InsertNetworkProfile(c *Client, body NetworkProfileBody) (NetworkProfileRes
resp := NetworkProfileResult{}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return resp, err
}

req, err := http.NewRequest("POST", fmt.Sprintf("%s/admin/hybridity/api/networks", c.HostURL), &buf)
if err != nil {
Expand Down Expand Up @@ -111,7 +115,11 @@ func GetNetworkProfile(c *Client, name string) (NetworkProfileBody, error) {
}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return NetworkProfileBody{}, err
}

req, err := http.NewRequest("POST", fmt.Sprintf("%s/hybridity/api/networks?action=queryIpUsage", c.HostURL), &buf)
if err != nil {
Expand Down Expand Up @@ -154,7 +162,11 @@ func GetNetworkProfileById(c *Client, id string) (NetworkProfileBody, error) {
}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return NetworkProfileBody{}, err
}

req, err := http.NewRequest("POST", fmt.Sprintf("%s/hybridity/api/networks?action=queryIpUsage", c.HostURL), &buf)
if err != nil {
Expand Down Expand Up @@ -219,7 +231,11 @@ func UpdateNetworkProfile(c *Client, body NetworkProfileBody) (NetworkProfileRes
resp := NetworkProfileResult{}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return resp, err
}

req, err := http.NewRequest("PUT", fmt.Sprintf("%s/hybridity/api/networks/%s", c.HostURL, body.ObjectId), &buf)
if err != nil {
Expand Down
6 changes: 5 additions & 1 deletion hcx/role_mapping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ func PutRoleMapping(c *Client, body []RoleMapping) (RoleMappingResult, error) {
resp := RoleMappingResult{}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return resp, err
}

req, err := http.NewRequest("PUT", fmt.Sprintf("%s:9443/api/admin/global/config/roleMappings", c.HostURL), &buf)
if err != nil {
Expand Down
6 changes: 5 additions & 1 deletion hcx/service_mesh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ func InsertServiceMesh(c *Client, body InsertServiceMeshBody) (InsertServiceMesh
resp := InsertServiceMeshResult{}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return resp, err
}

req, err := http.NewRequest("POST", fmt.Sprintf("%s/hybridity/api/interconnect/serviceMesh", c.HostURL), &buf)
if err != nil {
Expand Down
6 changes: 5 additions & 1 deletion hcx/site_pairing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ func InsertSitePairing(c *Client, body RemoteCloudConfigBody) (PostRemoteCloudCo
resp := PostRemoteCloudConfigResult{}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return resp, err
}

req, err := http.NewRequest("POST", fmt.Sprintf("%s/hybridity/api/cloudConfigs", c.HostURL), &buf)
if err != nil {
Expand Down
12 changes: 10 additions & 2 deletions hcx/sso.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@ func InsertSSO(c *Client, body InsertSSOBody) (InsertSSOResult, error) {
resp := InsertSSOResult{}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return resp, err
}

req, err := http.NewRequest("POST", fmt.Sprintf("%s:9443/api/admin/global/config/lookupservice", c.HostURL), &buf)
if err != nil {
Expand Down Expand Up @@ -106,7 +110,11 @@ func UpdateSSO(c *Client, body InsertSSOBody) (InsertSSOResult, error) {
resp := InsertSSOResult{}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return resp, err
}

req, err := http.NewRequest("POST", fmt.Sprintf("%s:9443/api/admin/global/config/lookupservice/%s", c.HostURL, body.Data.Items[0].Config.UUID), &buf)
if err != nil {
Expand Down
54 changes: 45 additions & 9 deletions hcx/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,11 @@ func GetLocalContainer(c *Client) (PostResouceContainerListResultDataItem, error
}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return PostResouceContainerListResultDataItem{}, err
}

resp := PostResouceContainerListResult{}

Expand Down Expand Up @@ -342,7 +346,11 @@ func GetRemoteContainer(c *Client) (PostResouceContainerListResultDataItem, erro
}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return PostResouceContainerListResultDataItem{}, err
}

resp := PostResouceContainerListResult{}

Expand Down Expand Up @@ -381,7 +389,11 @@ func GetNetworkBacking(c *Client, endpointid string, network string, network_typ
}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return Dvpg{}, err
}

resp := PostNetworkBackingResult{}

Expand Down Expand Up @@ -461,7 +473,11 @@ func GetVcDatastore(c *Client, datastore_name string, vcuuid string, cluster str
}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return GetVcDatastoreResultDataItem{}, err
}

resp := GetVcDatastoreResult{}

Expand Down Expand Up @@ -506,7 +522,11 @@ func GetVcDvs(c *Client, dvs_name string, vcuuid string, cluster string) (GetVcD
}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return GetVcDvsResultDataItem{}, err
}

resp := GetVcDvsResult{}

Expand Down Expand Up @@ -549,7 +569,11 @@ func GetRemoteCloudList(c *Client) (PostCloudListResult, error) {
}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return PostCloudListResult{}, err
}

resp := PostCloudListResult{}

Expand Down Expand Up @@ -586,7 +610,11 @@ func GetLocalCloudList(c *Client) (PostCloudListResult, error) {
}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return PostCloudListResult{}, err
}

resp := PostCloudListResult{}

Expand Down Expand Up @@ -624,7 +652,11 @@ func GetAppliance(c *Client, endpointId string, service_mesh_id string) (GetAppl
}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return GetApplianceResultItem{}, err
}

resp := GetApplianceResult{}

Expand Down Expand Up @@ -669,7 +701,11 @@ func GetAppliances(c *Client, endpointId string, service_mesh_id string) ([]GetA
}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return []GetApplianceResultItem{}, err
}

resp := GetApplianceResult{}

Expand Down
6 changes: 5 additions & 1 deletion hcx/vcenter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,11 @@ func InsertvCenter(c *Client, body InsertvCenterBody) (InsertvCenterResult, erro
resp := InsertvCenterResult{}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return resp, err
}

req, err := http.NewRequest("POST", fmt.Sprintf("%s:9443/api/admin/global/config/vcenter", c.HostURL), &buf)
if err != nil {
Expand Down
6 changes: 5 additions & 1 deletion hcx/vmc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,11 @@ func CloudAuthenticate(client *Client, token string) error {
}

var buf bytes.Buffer
json.NewEncoder(&buf).Encode(body)
err := json.NewEncoder(&buf).Encode(body)
if err != nil {
fmt.Println(err)
return err
}

req, err := http.NewRequest("POST", fmt.Sprintf("%s/api/sessions", c.HostURL), &buf)
if err != nil {
Expand Down
6 changes: 3 additions & 3 deletions resource_compute_profile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,12 +299,12 @@ func resourceComputeProfileCreate(ctx context.Context, d *schema.ResourceData, m
}

buf := new(bytes.Buffer)
json.NewEncoder(buf).Encode(body)
if err := json.NewEncoder(buf).Encode(body); err != nil {
return diag.FromErr(err)
}

res2, err := hcx.InsertComputeProfile(client, body)

if err != nil {
//return diag.FromErr(errors.New(fmt.Sprintf("%s", buf)))
return diag.FromErr(err)
}

Expand Down
4 changes: 3 additions & 1 deletion resource_l2_extension.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ func resourceL2ExtensionCreate(ctx context.Context, d *schema.ResourceData, m in
}

buf := new(bytes.Buffer)
json.NewEncoder(buf).Encode(body)
if err := json.NewEncoder(buf).Encode(body); err != nil {
return diag.FromErr(err)
}

res2, err := hcx.InsertL2Extension(client, body)

Expand Down
5 changes: 3 additions & 2 deletions resource_service_mesh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,12 +184,13 @@ func resourceServiceMeshCreate(ctx context.Context, d *schema.ResourceData, m in
}

buf := new(bytes.Buffer)
json.NewEncoder(buf).Encode(body)
if err := json.NewEncoder(buf).Encode(body); err != nil {
return diag.FromErr(err)
}

res2, err := hcx.InsertServiceMesh(client, body)

if err != nil {
//return diag.FromErr(errors.New(fmt.Sprintf("%s", buf)))
return diag.FromErr(err)
}

Expand Down
Loading
Loading