Configure project and VPC at provider level #1226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add VPC to context and handle it accordingly in tests and wrappers. Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
vpc-config-provider
branch
from
398ba04
to
cb6c1fe
Compare
|
/test-all |
ksamoray
force-pushed
the
vpc-config-provider
branch
2 times, most recently
from
7faf9c1
to
335a5eb
Compare
Allow configuration of the attributes above in the provider globally for the whole context, instead of the resource level. Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
vpc-config-provider
branch
from
335a5eb
to
b2db212
Compare
|
/test-all |
|
I think that I should add some tests for this case as well. |
|
To avoid confusion, I suggest erroring out in case different vpcs are specified on provider level and in the resource |
|
/test-all |
To handle invalid configuration of a context in both object and provider levels. Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
vpc-config-provider
branch
from
8b24632
to
1a0b9e0
Compare
|
/test-all |
|
@ksamoray, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
vpc-config-provider
branch
from
060577c
to
131fb99
Compare
Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
vpc-config-provider
branch
7 times, most recently
from
34f59eb
to
ddfeb34
Compare
Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
vpc-config-provider
branch
from
ddfeb34
to
961b1e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuration of the attributes above in the provider globally for the whole context, instead of the resource level.