Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove use of io/ioutil #1421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tenthirtyam
Copy link
Collaborator

Summary of Pull Request

Removes the use of io/ioutil.

As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations are preferred in new code.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Removes the use of `io/ioutil`.

As of Go 1.16, the same functionality is now provided by package `io` or package `os`, and those implementations are preferred in new code.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added the chore Chore label Oct 12, 2024
@tenthirtyam tenthirtyam self-assigned this Oct 12, 2024
@tenthirtyam tenthirtyam added needs-review Needs Review size/s Relative Sizing: small labels Oct 12, 2024
@ksamoray
Copy link
Collaborator

Code LGTM - would wait until we reestablish our acceptance tests CI env to validate this change

@tenthirtyam tenthirtyam requested review from a team and removed request for annakhm October 28, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore needs-review Needs Review size/s Relative Sizing: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants