Fix crash related to empty block in lb_vs resource #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty block can be configured when no required attributes are defined in the block. In this case nil protection is required, since empty block is presented as nil rather than empty map in the schema structure. Signed-off-by: Anna Khmelnitsky <[email protected]>
ksamoray
reviewed
Nov 6, 2024
| @@ -903,6 +903,10 @@ func getPolicyLbRuleVariablePersistenceLearnActionSchema() *schema.Schema { | |||
| func getPolicyClientSSLBindingFromSchema(d *schema.ResourceData) *model.LBClientSslProfileBinding { | |||
| bindings := d.Get("client_ssl").([]interface{}) | |||
| for _, binding := range bindings { | |||
| if binding == nil { | |||
There was a problem hiding this comment.
This is unsafe as d.Get() result can be nil as well and casting it will result a crash.
As we have multiple instances in the scope of this resource and multiple others in other resources, can we use a func instead of the range which will do all the validations, e.g check that input (d.Get() result) is not null, that members aren't null as well etc?
e.g:
func iterateSchemaSlice(s interface{}, f func(interface{})) {
if s == nil {
return
}
for _, i := range s.([]interface{}) {
if i == nil {
continue
}
f(i)
}
}
And call it as:
iterateSchemaSlice(d.Get("client_ssl"), func(binding interface{}){
data := binding.(map[string]interface{})
chainDepth := int64(data["certificate_chain_depth"].(int))
})
There was a problem hiding this comment.
If the key exists in schema, then nil is not expected to be returned, as stated here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty block can be configured when no required attributes are defined in the block. In this case nil protection is required, since empty block is presented as nil rather than empty map in the schema structure.