Add VPC attachment resource #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
--- PASS: TestAccResourceNsxtVpc_basic (72.41s) |
tenthirtyam
requested changes
Nov 10, 2024
nsxt/provider.go
Outdated
Comment on lines
530
to
533
| "nsxt_vpc_dhcp_v4_static_binding": resourceNsxtVpcSubnetDhcpV4StaticBindingConfig(), | ||
| "nsxt_vpc_attachment": resourceNsxtVpcAttachment(), | ||
| }, | ||
|
|
There was a problem hiding this comment.
I'd suggest this be the first in the lists of nsxt_vpc_* items (as well as ensure all listed resources and data sources are listed alphabetically.)
nsxt/resource_nsxt_vpc_attachment.go
Outdated
|
|
||
| id := d.Id() | ||
| if id == "" { | ||
| return fmt.Errorf("Error obtaining VpcAttachment ID") |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("Error obtaining VpcAttachment ID") | |
| return fmt.Errorf("error obtaining VpcAttachment ID") |
nsxt/resource_nsxt_vpc_attachment.go
Outdated
|
|
||
| id := d.Id() | ||
| if id == "" { | ||
| return fmt.Errorf("Error obtaining VpcAttachment ID") |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("Error obtaining VpcAttachment ID") | |
| return fmt.Errorf("error obtaining VpcAttachment ID") |
nsxt/resource_nsxt_vpc_attachment.go
Outdated
| func resourceNsxtVpcAttachmentDelete(d *schema.ResourceData, m interface{}) error { | ||
| id := d.Id() | ||
| if id == "" { | ||
| return fmt.Errorf("Error obtaining VpcAttachment ID") |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("Error obtaining VpcAttachment ID") | |
| return fmt.Errorf("error obtaining VpcAttachment ID") |
This is the new way of attaching connectivity profile to vpc, hence the profile attribute is also removed from vpc resource Signed-off-by: Anna Khmelnitsky <[email protected]>
annakhm
force-pushed
the
vpc-attachment-resource
branch
from
8aab5af
to
066ad49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the new way of attaching connectivity profile to vpc, hence the profile attribute is also removed from vpc resource