-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #1218
Merged
Merged
Fix tests #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
adambarreiro
requested review from
lvirbalas,
Didainius and
dataclouder
as code owners
March 12, 2024 11:09
Didainius
approved these changes
Mar 12, 2024
dataclouder
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Two small changes required.
Signed-off-by: abarreiro <[email protected]>
lvirbalas
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestAccDataSourceNotFound
sovcd_cse_kubernetes_cluster
(introduced in Add a specific resource/data source to create, read, update and delete CSE Kubernetes clusters #1195) is ignored.TestAccDataSourceNotFound
sovcd_version
(introduced in Add a specific resource/data source to create, read, update and delete CSE Kubernetes clusters #1195) is ignored.vcd_cse_kubernetes_cluster
data source, which requires the specialcse
config block.TestAccVcdCseKubernetesCluster
.TestAccVcdNetworkRoutedV2NsxtRouteAdvertisement
andTestAccVcdVAppVmCopyDifferentVdc
to not to be run with org user..changes/v3.12.0/1210-improvements.md
which had an incorrect file name.TestAccVcdVersion-step2
binary test (it needed to be skipped)