[RunAction, logging] (#159) Restored System and Server logs in VRDT OUTPUT #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihail Penchev (c) <[email protected]>
bcpmihail
added
type:bug
9 tasks
| @@ -321,8 +321,7 @@ export class VroRestClient { | |||
| "GET", | |||
| `workflows/${workflowId}/executions/${executionId}/syslogs` + | |||
| `?conditions=severity=${severity}` + | |||
| `&conditions=timestamp${encodeURIComponent(">")}${timestamp}` + | |||
| "&conditions=type=system" | |||
| `&conditions=timestamp${encodeURIComponent(">")}${timestamp}` // + "&conditions=type=system" | |||
There was a problem hiding this comment.
I think we can remove the commented condition, probably we won't need it anymore
Signed-off-by: Venelin Bakalov <[email protected]>
Signed-off-by: Mihail Penchev (c) <[email protected]>
Signed-off-by: Mihail Penchev (c) <[email protected]>
VenelinBakalov
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restored System and Server logs in VRDT OUTPUT.
Fetching logs via API call depending on the configured Vrdev Log level in the plugin settings.
Requires changes to the Run Script XML WF in BTVA > packages > exec (see related PR).
Checklist
Fixed #XXX -orClosed #XXX -prefix to auto-close the issueTesting
Tested by running a JS action (without return type and parameters) from a test project in:
Release Notes
Screenshot
Related issues and PRs
VRDT issue: #159
Related BTVA PR: vmware/build-tools-for-vmware-aria#450