Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide rooms on overview page while preview image fails to load #207

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mstock
Copy link

@mstock mstock commented Dec 30, 2022

This fixes the automatic update of preview/teaser images on the overview page (in the first commit) and also hides/shows rooms on the overview page depending on successful loading of the preview image, assuming that a stream is 'live' when the preview image can be loaded.

The change was inspired by a suggestion from @saerdnaer in the #voc-lounge, where I missed the part about fixing this on media.ccc.de at first and implemented it for the streaming website instead, which has a somewhat similar issue - and where implementing this is probably a bit easier. I'm not sure it's a good idea though to do this on the overview page, as it renders rooms where loading of the preview image fails 'inaccessible', so I don't mind if this PR gets discarded.

@saerdnaer
Copy link
Member

We could add an "show all" button or switch...

The old selector didn't match any elements on the overview page anymore,
which broke the teaser image update.
This assumes that a room isn't 'live' when it is configured to have a
preview image but it cannot currently be loaded.
@mstock mstock force-pushed the feature/hide-previewless-rooms branch from 9c7a534 to 619a5fa Compare February 25, 2023 14:07
@mstock mstock force-pushed the feature/hide-previewless-rooms branch from 619a5fa to 0c2cecc Compare February 25, 2023 14:11
@mstock
Copy link
Author

mstock commented Feb 25, 2023

I've given the idea with the button a try, rebased everything on the current master and force-pushed this today. Each group now gets a button which allows to toggle the display of rooms with inactive streams.

@saerdnaer
Copy link
Member

@iSchluff Do you have time to resolve the merge conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants