Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor paginator #12

Closed
wants to merge 1 commit into from
Closed

Conversation

selankon
Copy link
Collaborator

Now the useRoutedPagination return the page - 1 in order to avoid resting the page outside the paginator component.

On this way, the buttons and the url starts at 1 but the page used on the code is the "0".

Now the useRoutedPagination return the `page - 1` in order to avoid resting the page outside the paginator component.

On this way, the buttons and the url starts at 1 but the page used on the code is the "0".
@selankon selankon force-pushed the f/expose-routed-paginator-page branch from bde220a to fa79dc4 Compare June 17, 2024 12:59
Copy link

Copy link

@github-actions github-actions bot temporarily deployed to pull request June 17, 2024 13:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 17, 2024 13:00 Inactive
Copy link
Member

@elboletaire elboletaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me to talk about this tomorrow; there are some things I don't get.

@selankon
Copy link
Collaborator Author

I close this issue beacuse we are refactoring the response of organizations, process list etc to return the total count of occurrences.

When vocdoni/interoperability#188 fixed we should reopen this again

@selankon selankon closed this Jun 19, 2024
@elboletaire elboletaire deleted the f/expose-routed-paginator-page branch August 23, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants