-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: members invitations #22
Conversation
If I understand, when you are inviting somebody and the account doesn't exist, you have to provide the specific information to create this account. Imo I think this is not how it should work, actually the ui looks like: So simplifying:
I am correct with this description @jpaulet ?? |
Right now the backend needs some information about new users to create them in the database. It is needed because of the validations we implement in the database, such as uniqueness and non-empty first and last name, or phone number. If we want to support invitations for non-users without this information, we need to implement an intermediate status for these users, to give them the possibility to fill this information before receiving the invitation code. The current behavior has been defined to use the current "reset password" flow for simplicity. |
Imho we cannot create a user on the database only inviting it from the admin control panel. In addition, an admin could not know the phone number or the last name. After talk with @jpaulet we talk that the only thing needed to invite someone is to use the email. If when accessing to the invite link the user is not loged in, the signup form will be shown, and the invited organization will be added as default. Probably we could add a inviteCode parameter when sending the signup form and provably will need a table that relation invite codes and emails. But i can be wrong, @jpaulet could you explain detailed how the UX should work? |
Yes, the flow is as follows: 1 - Send a invitation (via only mail) I think that the best way to do it, is create a new table for the In this way, the admin that invites another one, only needs to fill the mail (as the design) and is not "creating" the user, only the invitation. When the user performs the action (accept the invite / register) then the new user is created. @selankon @emmdim @lucasmenendez if there is any more doubts, let me know or comment it in the tech weekly. |
I have some doubts about the behavior:
cc/ @jpaulet |
1 - By now yes. Only via mail. We will think if it's make sense in the future to send a SMS or do the same mechanism but instead of receiving it in a email, receiving it in a SMS (with a link and everything). 2 - Renounce = "delete account" (we will have to implement this). Be kicked out, right now no, but in the end we will have to implement something similar to this, admins can kick out administrators and viewers, and the "founding" admin (owner) can kick other admins. But right now, we stick to an MVP (but if it helps to the design, go ahead). 3 - No, after one week they expire. This way we keep the table clean (delete them after accepting or after 1 week). If you have more doubts, let me know. |
Update
|
c3ea982
to
4bf295f
Compare
New endpoint to invite new organization members: