Fixes and (kinda breaking) changes

- Ensure the `connected` field is properly checked via
  Object.keys().length
- Remove SpreadsheetAccess component logic from VoteButton (import it on
  your own if you need it, this is the most breaking change)
- Use election context instead of clients one (refs #171)

packages/chakra-components/src/components/Election/SpreadsheetAccess.tsx

@@ -49,9 +49,10 @@ export const SpreadsheetAccess = (rest: ChakraProps) => {
   const { connected, clearClient } = useElection()
   const [loading, setLoading] = useState<boolean>(false)
   const toast = useToast()
-  const { env, client: cl } = useClient()
+  const { env } = useClient()
   const {
     election,
+    client: cl,
     setClient,
     localize,
     sikPassword,
@@ -84,6 +85,7 @@ export const SpreadsheetAccess = (rest: ChakraProps) => {
         setClient(client)
       } catch (error) {
         console.warn('Error trying to login with private key ', error)
+        // this should not be required... if it fails, the client should already be the one set
         setClient(cl)
       }
     })()

packages/chakra-components/src/components/Election/VoteButton.tsx

@@ -7,14 +7,12 @@ import { ArchivedElection, ElectionStatus, InvalidElection, PublishedElection }
 import { useEffect, useState } from 'react'
 import { Button } from '../layout/Button'
 import { results } from './Results'
-import { SpreadsheetAccess } from './SpreadsheetAccess'
 
 export const VoteButton = (props: ButtonProps) => {
   const { connected } = useClient()
   const {
     client,
     loading: { voting },
-    connected: lconnected,
     ConnectButton,
     isAbleToVote,
     election,
@@ -35,10 +33,6 @@ export const VoteButton = (props: ButtonProps) => {
     return <ConnectButton />
   }
 
-  if (!lconnected && election.get('census.type') === 'spreadsheet') {
-    return <SpreadsheetAccess />
-  }
-
   const button: ButtonProps = {
     type: 'submit',
     ...props,

packages/react-providers/src/client/use-client-reducer.ts

@@ -270,7 +270,7 @@ const clientReducer: Reducer<ClientState, ClientAction> = (state: ClientState, a
       return {
         ...state,
         client,
-        connected: !!client.wallet,
+        connected: client.wallet ? !!Object.keys(client.wallet as unknown as any).length : false,
       }
     }
     case ClientEnvSet: {
@@ -285,7 +285,7 @@ const clientReducer: Reducer<ClientState, ClientAction> = (state: ClientState, a
         client,
         census3,
         env,
-        connected: !!client.wallet,
+        connected: client.wallet ? !!Object.keys(client.wallet as unknown as any).length : false,
       }
     }
     case ClientSignerSet: {
@@ -295,7 +295,7 @@ const clientReducer: Reducer<ClientState, ClientAction> = (state: ClientState, a
         ...state,
         client,
         signer,
-        connected: !!client.wallet,
+        connected: client.wallet ? !!Object.keys(client.wallet as unknown as any).length : false,
       }
     }
     default: