Election related actions should be using the client instance from useElection, instead of the one by useClient. #171
Labels
Comments
elboletaire
added a commit
that referenced
this issue
Jun 13, 2024
- Ensure the `connected` field is properly checked via Object.keys().length - Remove SpreadsheetAccess component logic from VoteButton (import it on your own if you need it, this is the most breaking change) - Use election context instead of clients one (refs #171)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given the scope of the different clients (which can be the same in many scenarios), and after trying to manually set a custom client in a custom implementation, we realize some internal calls related to elections (like fetching the census, for example), are using the client instance from the parent ClientProvider, instead of using the one from the ElectionProvider. This causes confusion, since using the
setClientfromuseElectionwill not work in many cases.All election related actions should prioritize the client set in useElection rather than the one from useClient.
The text was updated successfully, but these errors were encountered: