api: /chain/dateToBlock fix overflow for big timestamps #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordipainan
force-pushed
the
fix/estimateBlock
branch
from
756b8fb
to
c133768
Compare
jordipainan
force-pushed
the
fix/estimateBlock
branch
from
c133768
to
abda029
Compare
p4u
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that we found a bug on /chain/dateToBlock that happens when big timestamps are used.
Since the difftime is multiplied by 1000 this can lead to overflows because of the use of uint32.
This fix makes the proper changes for using uint64 and also that checks for overflows.