Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer: GetEnvelope now includes VoterID in returned envelope #1030

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

altergui
Copy link
Contributor

@altergui altergui commented Jul 5, 2023

Until now, the returned envelope was missing this field,
causing the endpoint GET /votes/{voteId} to return a nil VoterID

Until now, the returned envelope was missing this field,
causing the endpoint `GET /votes/{voteId}` to return a nil VoterID
@altergui altergui requested a review from jordipainan July 5, 2023 07:49
@altergui
Copy link
Contributor Author

altergui commented Jul 5, 2023

i dug into this while working on #1028

// TODO (painan): check why the voterID is not present on the reply
//qt.Assert(t, v2.VoterID.String(), qt.Equals, voterKey.AddressString())

i'm not uncommenting that line on this PR (now it works) since i'm refactoring the whole thing on #1028

@altergui altergui self-assigned this Jul 5, 2023
@p4u p4u merged commit afa3d8c into main Jul 5, 2023
9 checks passed
@p4u p4u deleted the hotfix/missing-voterid-in-getvote branch July 5, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants