api: implement pagination and query params for /chain/transfers #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elboletaire
approved these changes
Aug 6, 2024
altergui
force-pushed
the
feat/api-transfers-pagination
branch
2 times, most recently
from
856bdf7
to
e3da561
Compare
Pull Request Test Coverage Report for Build 10282805123Details
💛 - Coveralls |
63 tasks
…rams
add a new endpoint, that includes `pagination` field in reply, and accepts QueryParams:
* GET /chain/transfers
* page
* limit
* accountId
* accountIdFrom
* accountIdTo
* mark all of these endpoints as deprecated on swagger docs:
* /accounts/{accountId}/transfers/page/{page}
* /accounts/{accountId}/fees/page/{page}
* introduced a breaking change in the endpoint `/accounts/{accountId}/transfers/page/{page}`
since now the returned json structure changed.
now it's a plain list of transfers instead of "received" and "sent"
also fixed the encoding of the txHash field, now is base16 instead of base64
* api: add structs TransfersList, TransfersParams
* indexer: replace GetTokenTransfersBy*Account methods with a new TokenTransfersList
altergui
force-pushed
the
feat/api-transfers-pagination
branch
from
e3da561
to
1c62c0c
Compare
elboletaire
reviewed
Aug 7, 2024
…tFound, ErrOrgNotFound * add tests to avoid regressions
altergui
force-pushed
the
feat/api-transfers-pagination
branch
from
1c62c0c
to
ca3f738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a new endpoint, that includes
paginationfield in reply, and accepts QueryParams:GET /chain/transfers
mark all of these endpoints as deprecated on swagger docs:
api: add TransfersList struct
indexer: replace GetTokenTransfersBy*Account methods with a new TokenTransfersList