api: endpoint /accounts/{accountId} now includes transfersCount and feesCount #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selankon
approved these changes
Aug 7, 2024
selankon
requested changes
Aug 7, 2024
Pull Request Test Coverage Report for Build 10284564404Details
💛 - Coveralls |
these filters now return an empty list (not an error) * /accounts?accountId=foobar * /elections?electionId=foobar * /chain/organizations?organizationId=foobar so the errors ErrAccountNotFound, ErrElectionNotFound, ErrOrgNotFound happen only on: * /chain/transfers?accountId=foobar * /chain/fees?accountId=foobar * /votes?electionId=foobar * /elections?organizationId=foobar
altergui
force-pushed
the
feat/api-counts
branch
from
8ade2c5
to
9fbbbab
Compare
altergui
force-pushed
the
feat/api-counts
branch
from
9fbbbab
to
2491a75
Compare
selankon
approved these changes
Aug 7, 2024
|
included some more fixes, as separate commits since not directly related to the original PR. merging without squashing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1357