Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to go 1.23.0 #1379

Merged
merged 2 commits into from
Sep 9, 2024
Merged

update to go 1.23.0 #1379

merged 2 commits into from
Sep 9, 2024

Conversation

p4u
Copy link
Member

@p4u p4u commented Sep 3, 2024

No description provided.

@p4u
Copy link
Member Author

p4u commented Sep 3, 2024

Any glue why this is happening @altergui?

@altergui
Copy link
Contributor

altergui commented Sep 3, 2024

#16 0.063 go: go.mod requires go >= 1.23.0 (running go 1.22.6; GOTOOLCHAIN=local)
#16 ERROR: process "/bin/sh -c go mod download -x" did not complete successfully: exit code: 1

maybe something outdated at the runner? i'm taking a look

@altergui
Copy link
Contributor

altergui commented Sep 3, 2024

ok so wait, actually the failing job is the scan-vuln-deps that we seldom maintain, i'd bet there's some action that needs to be bumped (happened to me in the past). but maybe we could simply drop that action altogether, due to lack of maintenance.

@p4u
Copy link
Member Author

p4u commented Sep 4, 2024

I'd drop it @altergui

altergui and others added 2 commits September 9, 2024 09:17
it's unmaintained and fails on go 1.23.0
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10768432327

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.397%

Totals Coverage Status
Change from base Build 10737162384: 0.0%
Covered Lines: 16806
Relevant Lines: 26934

💛 - Coveralls

@altergui altergui self-requested a review September 9, 2024 11:16
@altergui altergui merged commit 7f53ca4 into main Sep 9, 2024
10 checks passed
@altergui altergui deleted the f/update_go branch September 9, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants