Make Pinecone implementation nonblocking #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajar98
requested changes
Aug 1, 2023
ajar98
approved these changes
Aug 1, 2023
| else: | ||
| params["model"] = model | ||
|
|
||
| return list((await openai.Embedding.acreate(**params))["data"][0]["embedding"]) |
There was a problem hiding this comment.
(fast follow) this should have some error handling
m5a0r7
pushed a commit
to m5a0r7/vocode-python
that referenced
this pull request
Oct 19, 2023
* similarity_search_with_score works but add_texts does not * Make upsert work * Terminate aiohttp session if vector db exists * Add langchain comment * Move terminate code to base_agent * Make embedding function async * Fix mypy * Add aiohttp_session parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.