-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inputs Needed] Add New VectorDB PGVector #475
base: main
Are you sure you want to change the base?
Conversation
Hello @rahulbansal16, I think it's a good idea to use 'vecs', but keeping this in mind. supabase/vecs#6 Are you in the Vocode Open Source Discord community? |
Hey @arpagon I have joined the discord. They have the goal to make vecs async in the near future. And will remove the thread when vecs is done with the async support. Let me know if you have a different approach. |
I have updated the code and wrapped the insert and query method in the asyncio threads. Since it's postgres. It's recommended to create the indexes before querrying. |
I did not find any test for other vector db. |
While other vector db tests might be missing, writing tests for pg_vector is crucial for confidence, stability, and adoption. It benefits both your project and the community. Thorough tests build trust, encouraging wider use and contributions. Don't hesitate to ask for help getting started – the community is here to support you! |
@arpagon I will add them, I am occupied with other work but will be able to contribute on weekend. |
Hello @rahulbansal16 I'm interested in using this patch. Is it in a stable enough state that I can use it? |
@rjheeta I have not written test for it but I was able to test the functionality and it was working. |
Perfect, thank you. I will give this a shot. @arpagon At a high level, what tests are you looking for in order to merge & support this change? Maybe I can try to help with writing some of these? |
I am working on the issue.
Here is the current progress.
Pending Items
Need inputs should we use vecs (It's new SDK from supabase) or use the ORM sqlalchemy.Make the upsert method for the add_text async.The flow for creating indexs on the vector table.