-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update transfer call to pass in the TN to transfer to #514
Conversation
@ajar98 Do you agree with this? Slight modification to allow LLM to pass in the phone number. |
…rectly passed to actions * This uses a more reliable method of obtaining these IDs (via ConversationStateManager)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjheeta actually, I think the user should be able to configure whether or not the LLM can choose the transfer number. Couple of ways to approach this:
- Make a separate vocode action with this config change (poor DRY)
- Make the configuration value optional (which would translate to sending GPT a schema where it is not required) - imo too much control to the LLM when this is something that is easily configurable pre call
- [preferred] somehow making
TransferCallParameters
only get the property ifto_phone
is None - likely requires a deeper change to the actions system
@ajar98 Thanks for the feedback! If you're open to giving a bit of guidance / direction on your indicated preferred route, I'm happy to take a stab at it. |
@rjheeta awesome! Really excited to work with you on this -
We can override this for [0] https://github.com/vocodedev/vocode-python/blob/main/vocode/streaming/action/base_action.py#L44-L46 |
@ajar98 Ajay, I just pushed an update. Could you have a look and advise if this is what you had in mind? Or let me know where/how I can improve it. |
* Update Readme with Preview Info * We're not quite that far along * Update Structure to be more Pleasing to the Eyes * Add changelog to readme --------- Co-authored-by: srhinos <[email protected]> Co-authored-by: Adnaan Sachidanandan <[email protected]>
* The Big Diff * remove tests on 3.8 and 3.9
* dispatch into elvenlabsws if experimental_websocket is on * fix mypy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @rjheeta , this is exactly what I had in mind 🎉
mind fixing the merge conflict? then should be g2g :)
a445ce1
to
e79522a
Compare
my history got mangled. Will re-do this on new branch |
All
TransferCall
action to acceptto_phone
as a parameter so the LLM can feed the TN to transfer to at runtime.