Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carry over change to remove runtime error on twilio 401 #580

Merged
merged 1 commit into from
Jun 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions vocode/streaming/telephony/client/twilio_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ class TwilioBadRequestException(ValueError):
pass


class TwilioException(ValueError):
pass


class TwilioClient(AbstractTelephonyClient):
def __init__(
self,
Expand Down Expand Up @@ -64,10 +68,11 @@ async def create_call(
)
raise TwilioBadRequestException(
"Telephony provider rejected call; this is usually due to a bad/malformed number. "
"If this persists, and you're sure that the number is well-formed, "
"please contact us."
)
raise RuntimeError(f"Failed to create call: {response.status} {response.reason}")
else:
raise TwilioException(
f"Twilio failed to create call: {response.status} {response.reason}"
)
response = await response.json()
return response["sid"]

Expand Down
Loading