Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passthrough of transport options #603

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Support passthrough of transport options #603

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
164e51b
Don't verify SSL on external action passthroughs
vocode-petern Jul 4, 2024
f387d78
Instead of explicitly setting verify to False, support specifying tra…
vocode-petern Jul 4, 2024
6d7fc43
Add transport_options to test case for sending external actions
vocode-petern Jul 4, 2024
9592eeb
Pass AsyncHTTPTransport object instead of configuration as parameter
vocode-petern Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/streaming/action/test_external_actions_requester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ async def test_send_request_responses(
JSON_SCHEMA,
base64.b64encode(os.urandom(32)).decode(),
additional_payload_values={"call_id": "call_id"},
transport_options={"retries": 3, "verify": True},
)

assert response.success is expected_success
Expand Down
3 changes: 2 additions & 1 deletion vocode/streaming/action/external_actions_requester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ async def send_request(
payload: Dict[str, Any],
signature_secret: str,
additional_payload_values: Dict[str, Any] = {},
transport_options: Dict[str, Any] = {"retries": 2},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we actually just pass through the AsyncHTTPTransport object? is better for typing and configurability I'd say

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered it originally but thought it would introduce potentially undesirable coupling. But I think it's good to be opinionated about some things even if it introduces some coupling -- made the change.

) -> ExternalActionResponse:
encoded_payload = json.dumps({"payload": payload} | additional_payload_values).encode(
"utf-8"
Expand All @@ -63,7 +64,7 @@ async def send_request(
"x-vocode-signature": self._encode_payload(encoded_payload, signature_secret),
}

transport = httpx.AsyncHTTPTransport(retries=2)
transport = httpx.AsyncHTTPTransport(**transport_options)
async with httpx.AsyncClient(
headers=headers,
transport=transport,
Expand Down
Loading