uses .value instead of passing enum for sampling rate #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnaans
approved these changes
Jul 5, 2024
ajar98
added a commit
that referenced
this pull request
Jul 6, 2024
ajar98
added a commit
that referenced
this pull request
Jul 8, 2024
* remove phantom parameter (#612) * support files in make transcribe (#610) * support files in make transcribe * switch comment * uses .value instead of passing enum for sampling rate (#613) * [hotfix] fix ref in make transcribe (#614) * [DOW-113] deprecate output queue and manually attach workers to each other (#593) * deprecate output queues * fix quickstarts * fix mypy * fix tests * fix mypy * adds comment * adds back streamingconversation test * make input queue private on AsyncWorker * update tests * resolve PR comments * create scripts for vocodehq-public (#615) * add script used to make PR * adds test target for vocodehq-public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discovered this when trying to run calls with the
InMemoryConfigManager- we should use this enum for comparison, but not use it as an enum to pass around valuesthis is hidden for phone calls that use Redis, since we serialize the Pydantic object which converts RATE_8000 --> 8000