Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exception logs for InterruptibleWorker and AsyncQueueWorker #624

Closed

Conversation

adnaans
Copy link
Contributor

@adnaans adnaans commented Jul 9, 2024

Both of these workers have a catch-all statement that raises a log on an exception instead of fully raising the error itself. This:

  1. Prevents the error from breaking the flow
  2. Causes sentry to catch the log separately from asyncio and raise the error twice

@adnaans adnaans requested a review from ajar98 July 9, 2024 22:34
Copy link

linear bot commented Jul 9, 2024

Copy link

github-actions bot commented Sep 9, 2024

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 9, 2024
Copy link

This PR has been automatically closed due to inactivity. Thank you for your contributions.

@github-actions github-actions bot closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants