-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate TypedModel and properly onboard pydantic v2 #630
Open
ajar98
wants to merge
8
commits into
main
Choose a base branch
from
ajay/typed-model-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajar98
force-pushed
the
ajay/typed-model-refactor
branch
from
July 12, 2024 21:19
8f899b0
to
325afc9
Compare
ajar98
force-pushed
the
ajay/typed-model-refactor
branch
from
July 12, 2024 22:01
325afc9
to
2331b1f
Compare
ajar98
changed the title
[WIP] typedmodel refactor
deprecate TypedModel and properly onboard pydantic v2
Jul 19, 2024
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This PR has been automatically closed due to inactivity. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes
TypedModel
and all that comes with it and replaces it withAdaptiveObject
allows us to properly move to pydantic v2 and not in half state as before, as well as allow us to create
PipelineConfig
in the telephony decoupling PR