Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate TypedModel and properly onboard pydantic v2 #630

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ajar98
Copy link
Contributor

@ajar98 ajar98 commented Jul 12, 2024

removes TypedModel and all that comes with it and replaces it with AdaptiveObject

allows us to properly move to pydantic v2 and not in half state as before, as well as allow us to create PipelineConfig in the telephony decoupling PR

  • adds a test for AdaptiveObject

@ajar98 ajar98 force-pushed the ajay/typed-model-refactor branch from 8f899b0 to 325afc9 Compare July 12, 2024 21:19
@ajar98 ajar98 force-pushed the ajay/typed-model-refactor branch from 325afc9 to 2331b1f Compare July 12, 2024 22:01
@ajar98 ajar98 linked an issue Jul 19, 2024 that may be closed by this pull request
@ajar98 ajar98 changed the title [WIP] typedmodel refactor deprecate TypedModel and properly onboard pydantic v2 Jul 19, 2024
@ajar98 ajar98 marked this pull request as ready for review July 19, 2024 19:17
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 18, 2024
Copy link

This PR has been automatically closed due to inactivity. Thank you for your contributions.

@github-actions github-actions bot closed this Sep 25, 2024
@ajar98 ajar98 reopened this Oct 2, 2024
@github-actions github-actions bot removed the stale label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate TypedModel and properly onboard pydantic v2
1 participant