Update vocodehq-public #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Bug-628] correct coding errors in the google synthesiser * create_speech --> create_speech_uncached --------- Co-authored-by: Ajay Raj <[email protected]>
* make terminate async * creates audio pipeline abstraction * fix streaming conversation api * make terminate() invocations in tests async * removes the vector_db.tear_down() call in streaming conversation
vocode-petern
approved these changes
Jul 12, 2024
| @@ -56,7 +56,7 @@ def synthesize(self, message: str) -> Any: | |||
| ) | |||
|
|
|||
| # TODO: make this nonblocking, see speech.TextToSpeechAsyncClient | |||
| async def create_speech( | |||
| async def create_speech_uncached( | |||
There was a problem hiding this comment.
Was this just broken before? Looks like it should have been create_speech_uncached all along
There was a problem hiding this comment.
yep, it was just broken :/
| @@ -75,7 +75,7 @@ async def create_speech( | |||
| in_memory_wav.setnchannels(1) | |||
| in_memory_wav.setsampwidth(2) | |||
| in_memory_wav.setframerate(output_sample_rate) | |||
| in_memory_wav.writeframes(response.audio_content) | |||
| in_memory_wav.writeframes(response.audio_content[44:]) | |||
There was a problem hiding this comment.
What's the significance of 44? I'm guessing there's some start sequence that's always prepended to the audio content? Is the audio content guaranteed to have a length of at least 44?
There was a problem hiding this comment.
44 is the size of the wave header, it shouldn't be a magic number really, but is okay for now
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the vocodehq-public branch by merging changes from the main branch.