Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RockPro64 platform image builder. #221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tiemenwerkman
Copy link

Add support for rockpro64 platform

Copy link
Contributor

@CameronNemo CameronNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not seem like you are finishing the _EOF. Probably needs to be changed.

rockpro64*)
rk33xx_flash_uboot "${ROOTFS}/usr/lib/rockpro64-uboot" "$LOOPDEV"
# populate the extlinux.conf file
cat >"${ROOTFS}/etc/default/extlinux" <<_EOF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you are missing a blurb here. See the Rock64 section above, which should work for the RP64 too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiemenwerkman I tested this branch and it works on my RockPro64. I noticed @CameronNemo's comments and made the following change locally when I built my image.

Suggested change
cat >"${ROOTFS}/etc/default/extlinux" <<_EOF
cat >"${ROOTFS}/etc/default/extlinux" <<_EOF
TIMEOUT=10
# Defaults to current kernel cmdline if left empty
CMDLINE="panic=10 coherent_pool=1M console=ttyS2,115200 root=UUID=${ROOT_UUID} rw"
# set this to use a DEVICETREEDIR line in place of an FDT line
USE_DEVICETREEDIR="yes"
# relative dtb path supplied to FDT line, as long as above is unset
DTBPATH=""
_EOF
mkdir -p "${ROOTFS}/boot/extlinux"
run_cmd_chroot "${ROOTFS}" "/etc/kernel.d/post-install/60-extlinux"

Thanks for putting this together. I got 3 RockPro64s a couple days ago and using this PR along with void-linux/void-packages#33556 I got VoidLinux installed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I changed from the Rock64 section above was setting the baud rate to 115200 to match the patch in your uboot patch. I have one of those USB TTL adapters that claim to work at higher speeds but all I see is garbage at 1.5Mbps so I appreciate the switch to 115200.

@Anachron
Copy link

Since live-images are not possible I've created a platformfs and will try to boot soon:

Successfully created /home/anon/.mkvr/images/void-platform-aarch64-20220317-rockpro64-de_DE.UTF-8.tar.xz (rockpro64)

tsndqst added a commit to tsndqst/void-mklive that referenced this pull request Mar 25, 2022
@Anachron
Copy link

Anachron commented Apr 4, 2022

@tiemenwerkman are you still maintaining this?

tsndqst added a commit to tsndqst/void-mklive that referenced this pull request Feb 26, 2023
tsndqst added a commit to tsndqst/void-mklive that referenced this pull request Dec 3, 2023
classabbyamp pushed a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants