Add option to ingore services #372
Conversation
Calandracas606
force-pushed
the
ignore-services
branch
from
c734ae1 to
9f9e4e4
Compare
|
as far as I remember, all services have to be explicitly enabled with an argument to mklive. Just don't list the services if you don't want them to be enabled. |
|
when using |
|
then just edit build-x86-images.sh, I don't see a reason to have a mklive.sh argument that removes services that were added by another argument, just remove it from that argument |
|
For more context, I'm ignoring some packages when building by using the The image fails to build because mklive.sh tries to enable the services which are provided by packages which have been ignored. This use case is very niche, and if this doesn't seem useful then go ahead and close the PR |
| @@ -153,10 +154,12 @@ ignore_packages() { | |||
| enable_services() { | |||
| SERVICE_LIST="$*" | |||
| for service in $SERVICE_LIST; do | |||
| if ! [ -e $ROOTFS/etc/sv/$service ]; then | |||
| die "service $service not in /etc/sv" | |||
| if ! [[ $IGNORE_SV =~ (^|[[:space:]])$service($|[[:space:]]) ]] ; then | |||
There was a problem hiding this comment.
as of #384 i've started moving these stringy arrays to bash arrays, would be nice to do here too.
imo this is the most concise way of checking for array membership: https://github.com/void-linux/void-packages/pull/42656/files#diff-2aed335c529e5e6ba673dd15b329eba3605f22c2762850121093db28c4fa2f93R325-R328
Pretty self explanatory. If I dont want to enable some services which would be enabled by default (elogind, polkit), I can disable them with
-D "elogind polkit"I'm not sure if I should be committing the generated content from
make README.md