Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: update to 88.0.1 #30718

Merged
merged 2 commits into from
May 12, 2021
Merged

firefox: update to 88.0.1 #30718

merged 2 commits into from
May 12, 2021

Conversation

dkwo
Copy link
Contributor

@dkwo dkwo commented May 7, 2021

  • firefox: update to 88.0.1
  • firefox-i18n: update to 88.0.1
  • firefox: add musl patch

I took the patch from Alpine, hoping that it would allow firefox to run on musl 1.2.2.
Possibly more patches are needed, but at least this one shouldn't do any damage.
I haven't built/tested it on musl yet.

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Builds on x86-64

[ci skip]

@ericonr
Copy link
Member

ericonr commented May 9, 2021

Firefox's crash on musl 1.2.2 should be related only to O_LARGEFILE changes that happened for x86_64 (all that needs to be done is build firefox with musl 1.2.2; alternatively, you can consider applying https://git.musl-libc.org/cgit/musl/commit/?id=b8b729bd22c28c9116c2fce65dce207a35299c26 to our musl package). @q66 mentioned he tested firefox with musl 1.2.2 on ppc64le-musl and didn't have any issues.

I'm not sure we should import this patch, unless you have context for what issue it's actually solving?

@ericonr
Copy link
Member

ericonr commented May 9, 2021

(sorry, I had missed the bug link in the patch)

but in that case, https://bugzilla.mozilla.org/show_bug.cgi?id=1657849#c2 shows that the patch doesn't solve an actual issue, since the hang was reproduced with seccomp disabled.

@ericonr
Copy link
Member

ericonr commented May 9, 2021

Once a7895ff is removed I'm okay with merging this, seems to be ok on musl.

@dkwo
Copy link
Contributor Author

dkwo commented May 10, 2021

I see, thanks for pointing this out.

@ericonr
Copy link
Member

ericonr commented May 12, 2021

I will merge this by itself, holding it up on #30777 isn't ideal.

@dkwo
Copy link
Contributor Author

dkwo commented May 12, 2021 via email

@ericonr ericonr merged commit 5089939 into void-linux:master May 12, 2021
@dkwo dkwo deleted the ff-musl branch May 13, 2021 14:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants