Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webkit2gtk: add patch to resolve unintended gst-plugins-bad1 dependency #39180

Closed
wants to merge 3 commits into from

Conversation

averycoolbean
Copy link

Testing the changes

  • I tested the changes in this PR:NO

Local build testing

  • I built this PR locally for my native architecture, (amd64-glibc)

this would properly resolve issue #34781 by applying the final fix already included in webkitgtk versions 2.36.4 and up

full credit for the fix goes to Philippe Normand here, i just copy-pasted it onto this older version to generate a fitting patch

@q66 you asked to be pinged before touching this package

@averycoolbean
Copy link
Author

saved as a draft cause i made a really silly mistake while generating the original patch file (kinda sorta missed an entire other file), ill commit the proper patch once ive built the package again to confirm it still builds without issue

@averycoolbean averycoolbean marked this pull request as ready for review September 9, 2022 06:25
@q66
Copy link
Contributor

q66 commented Sep 9, 2022

i will update webkitgtk to 2.36 later

that said, gst-plugins-bad should be a build dependency anyway because it enables functionality otherwise not available

@q66 q66 closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants