Tuner - new package #39774
Tuner - new package #39774
Conversation
Sorry, my mistake...
Sorry for the previous commits, they were a mistake... I'm kinda new :D.
|
I noticed when it finally built, the file names it provides are gross: |
|
the inverse-DNS naming scheme is fine. there's no need to change it |
| version=1.5.1 | ||
| revision=1 | ||
| build_style=meson | ||
| hostmakedepends="gettext pkg-config vala" |
There was a problem hiding this comment.
Seems glib-devel is needed as hostmakedepends as well to get the glib-compile-resources on cross targets
There was a problem hiding this comment.
I'm sorry, I'm kinda new to all this... are my last commits OK? :-\
There was a problem hiding this comment.
Should be good, with a few remarks:
- any blank lines are unnecessary
- we usually indent wrapped lines like the
makedependswith only one space
As mentioned below we do one commit per package, so you need to squash all these. In the future, you can use git commit --amend to add changes without introducing new commits.
There was a problem hiding this comment.
- any blank lines are unnecessary
I believe I had only one blank line at the end... POSIX standard I believe, everything ends with a new line... please correct me if I'm wrong :).
- we usually indent wrapped lines like the
makedependswith only one space
As in not do a bunch of spaces to align the indent? OK, no problem, feel free to correct the template and I will remember this for future commits ;).
As mentioned below we do one commit per package, so you need to squash all these. In the future, you can use
git commit --amendto add changes without introducing new commits.
I still haven't connected my main rig with GitHub, I'm still working on the web interface :-\... I know, I'll get on it as soon as possible.
Now, how do I squash the commits :). Might be a stupid question, I know, but as I said, I'm kinda new :).
There was a problem hiding this comment.
Now, how do I squash the commits
See "Squashing commits" in https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History, should be pretty clearly described (beware, git rebase -i sends you to the default editor, which might be vim on linux 😛)
There was a problem hiding this comment.
(beware,
git rebase -isends you to the default editor, which might be vim on linux 😛)
Hahahaha, good one :D. It's vi in my case I believe, it came preinstalled :D. Can't work it if my life depended on it xD.
Can't seem to find a way to squash the commits from this PR from the web UI, apparently a maintainer has to approve me since I'm a first-time contributor, and then another drop down menu appears... at least that's what I gathered from what I read :-\.
There was a problem hiding this comment.
That's easy to solve, don't use the web ui.
|
Also these commits should be squashed together into one |
Added geocode-glib-libsoup2-devel
Added geocode-glib-libsoup2-devel to makedepends
Added glib-devel for cross compiling
|
Are these commits OK? Also, it states the version is 1.5.0, but it's actually 1.5.1, the author just forgot to change the version number in the About. |
srcpkgs/tuner/template
Outdated
| revision=1 | ||
| build_style=meson | ||
| hostmakedepends="glib-devel gettext pkg-config vala" | ||
| makedepends="geoclue2-devel geocode-glib-devel geocode-glib-libsoup2-devel |
There was a problem hiding this comment.
you are mixing libsoup2 and libsoup3 versions of geocode-glib here, remove the libsoup3 one (geocode-glib-devel) or switch the whole package to libsoup3 if possible.
There was a problem hiding this comment.
Is this OK?
Can't switch to libsoup3, the package requires libsoup2.
There was a problem hiding this comment.
Yes, do you know if there is a plan to support libsoup3?
There was a problem hiding this comment.
Yes, do you know if there is a plan to support libsoup3?
No, I'm not in contact with the author. Would you like me to ask him/her?
EDIT: I asked on the GH project page, will post the reply.
Testing the changes